Fix cmake error when build with capstone as submodule #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rot127
approved these changes
Feb 2, 2025
|
I just saw this PR, it's fixing the same problem as #2629. |
|
Yes, but this is for the v5 branch. @WerWolv didn't seem to have time to fix the CI. |
|
Ah, I did overlook that this PR is targeting v5.
I personally don't use v5, but I'm happy happy to backport the fix (if needed there) as soon as it is merged in to the |
|
It would be pretty helpful. A lot of people use v5 still. Because they can't put the effort into changing to v6 currently (or don't get enough out of it). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Hey, really simple change making sure that cpack doesn't try to look for a LICENSE.TXT file in the main project root but in the current project root. This fixes the usecase where capstone is being included as a submodule and loaded using
add_subdirectoryin a cmake project. Previously it would look for LICENSE.TXT in the main project root directory, now it's looking for it in the capstone subdirectory.Test plan
add_subdirectory. Previously this would fail with a cpack error. Now it doesn't anymore.Closing issues